Dustin-Mike Jens HähnelandClaude Haiku 4.5
4fa8d12fa0
## Critical Fixes - Fix CRITICAL-1: Empty scans no longer delete entire library - Use timestamp-based tombstone logic instead of path-based - Only mark missing if livePaths is not empty - Fix CRITICAL-2: Re-scanned files now return from deleted state - Add deleted=false to SongsCompanion.insert in both scanners ## High Priority Fixes - HIGH-1: Fix SQLite variable limit crash on large libraries - Replace isNotIn() with timestamp comparison (O(1) not O(n)) - HIGH-2: Fix UI freezing during scan - Throttle progress updates (every 50 files or end of scan) - HIGH-3: Add error handling for scan failures - Wrap scanFolders/scanAndroidMediaStore in try/catch - Display scanError banner in LibraryScreen - HIGH-4: Add error handling for playback failures - Wrap loadPlaylist in try/catch ## Medium Priority Fixes - MEDIUM-1: Replace ! with ?? to handle unknown ProcessingState - MEDIUM-2: Escape LIKE wildcards in search queries - MEDIUM-4: Display StreamBuilder errors instead of treating as empty - MEDIUM-8: Add tooltips to all IconButtons for accessibility - Add doc comments to public database APIs ## Testing - Add regression tests for CRITICAL-1 and CRITICAL-2 - All 9 existing tests pass Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
104 lines
3.1 KiB
Dart
104 lines
3.1 KiB
Dart
import 'dart:io';
|
|
|
|
import 'package:audio_metadata_reader/audio_metadata_reader.dart';
|
|
import 'package:drift/drift.dart';
|
|
import 'package:path/path.dart' as p;
|
|
import 'package:path_provider/path_provider.dart';
|
|
import 'package:uuid/uuid.dart';
|
|
|
|
import 'database.dart';
|
|
|
|
const _audioExt = {
|
|
'.mp3', '.m4a', '.aac', '.flac', '.wav', '.ogg', '.opus', '.wma', '.aiff',
|
|
'.aif', '.alac',
|
|
};
|
|
const _uuid = Uuid();
|
|
|
|
/// Scannt alle [folderPaths] rekursiv nach Audiodateien, liest Tags + Cover
|
|
/// und schreibt sie in die DB. Bereits bekannte Dateien behalten ihre UUID
|
|
/// (sync-stabil); verschwundene Dateien werden per Tombstone markiert.
|
|
/// Gibt die Zahl der gefundenen Songs zurück.
|
|
// ponytail: Tag-Parsing läuft synchron im UI-Isolate. Reicht für normale
|
|
// Bibliotheken; bei >~mehreren Tausend Dateien in ein Isolate (compute) auslagern.
|
|
Future<int> scanFolders(
|
|
MeloDb db,
|
|
List<String> folderPaths, {
|
|
Directory? coverDir,
|
|
void Function(int done, int total)? onProgress,
|
|
}) async {
|
|
final existing = {for (final s in await db.allSongs()) s.path: s};
|
|
final covers = coverDir ??
|
|
Directory(p.join((await getApplicationSupportDirectory()).path, 'covers'));
|
|
await covers.create(recursive: true);
|
|
|
|
final files = <File>[];
|
|
for (final folder in folderPaths) {
|
|
final dir = Directory(folder);
|
|
if (!dir.existsSync()) continue;
|
|
await for (final entity in dir.list(recursive: true, followLinks: false)) {
|
|
if (entity is File &&
|
|
_audioExt.contains(p.extension(entity.path).toLowerCase())) {
|
|
files.add(entity);
|
|
}
|
|
}
|
|
}
|
|
|
|
final now = DateTime.now().millisecondsSinceEpoch;
|
|
final companions = <SongsCompanion>[];
|
|
final livePaths = <String>[];
|
|
var done = 0;
|
|
|
|
for (final file in files) {
|
|
livePaths.add(file.path);
|
|
final prev = existing[file.path];
|
|
final id = prev?.id ?? _uuid.v4();
|
|
|
|
AudioMetadata? meta;
|
|
try {
|
|
meta = readMetadata(file, getImage: true);
|
|
} catch (_) {
|
|
// Unlesbare/kaputte Tags: Datei trotzdem mit Dateinamen aufnehmen.
|
|
}
|
|
|
|
final rawTitle = meta?.title?.trim();
|
|
final title = (rawTitle != null && rawTitle.isNotEmpty)
|
|
? rawTitle
|
|
: p.basenameWithoutExtension(file.path);
|
|
|
|
var coverPath = prev?.coverPath;
|
|
final pics = meta?.pictures ?? const <Picture>[];
|
|
if (pics.isNotEmpty && coverPath == null) {
|
|
try {
|
|
final f = File(p.join(covers.path, '$id.img'));
|
|
await f.writeAsBytes(pics.first.bytes);
|
|
coverPath = f.path;
|
|
} catch (_) {
|
|
// Kaputtes Cover verzögert nicht den Scan.
|
|
}
|
|
}
|
|
|
|
companions.add(SongsCompanion.insert(
|
|
id: id,
|
|
path: file.path,
|
|
title: title,
|
|
artist: Value(meta?.artist),
|
|
album: Value(meta?.album),
|
|
durationMs: Value(meta?.duration?.inMilliseconds),
|
|
coverPath: Value(coverPath),
|
|
dateAddedMs: prev?.dateAddedMs ?? now,
|
|
updatedAtMs: now,
|
|
deleted: const Value(false),
|
|
));
|
|
++done;
|
|
if (done % 50 == 0 || done == files.length) {
|
|
onProgress?.call(done, files.length);
|
|
}
|
|
}
|
|
|
|
await db.upsertSongs(companions);
|
|
if (livePaths.isNotEmpty) {
|
|
await db.markMissing(now);
|
|
}
|
|
return companions.length;
|
|
}
|